Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount .docker dir to allow container to push to docker hub #1682

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

btoll
Copy link

@btoll btoll commented Nov 2, 2020

Summary

The container launched by the mule task creates and pushes a docker image to docker hub. The fix mounts the .docker directory that contains the docker credentials.

Test Plan

VERSION=2.2.0 NETWORK=betanet mule -f package-deploy.yaml docker-hub

- VERSION=$VERSION
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- $HOME/.docker:/root/.docker
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important bit.

Copy link
Contributor

@egieseke egieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@algojohnlee algojohnlee merged commit 3300ce3 into algorand:master Nov 5, 2020
@btoll btoll deleted the deploy_fixes branch November 5, 2020 15:53
tsachiherman pushed a commit to tsachiherman/go-algorand that referenced this pull request Jul 7, 2021
…1682)

The container launched by the mule task creates and pushes a docker image to docker hub. The fix mounts the .docker directory that contains the docker credentials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants